Skip to content

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

Tested locally to not wait for CI. Though it's very odd this could slip by before... The basictests.jl should fail if the triangular solve is off but they didn't in the previous merges so there is still something I don't understand here.

@ChrisRackauckas ChrisRackauckas merged commit 8645db7 into main Aug 6, 2025
106 of 118 checks passed
@oscardssmith oscardssmith deleted the ChrisRackauckas-patch-2 branch August 6, 2025 15:16
@hersle
Copy link

hersle commented Aug 7, 2025

@ChrisRackauckas Could this line prevent MKL from loading in the test? I think Github computers have AMD EPYC.

@ChrisRackauckas
Copy link
Member Author

Oh true. Hmm We might need to force alternative hardware on here so that MKL is hit. I used to always be testing that locally, but now I do more dev on my Mac so that is under tested 😅. I'll setup some self-hosted hardware to make sure this stays stable.

@hersle
Copy link

hersle commented Aug 7, 2025

I hit #679 on Github CI for my package, and manually enabled MKL to produce this documentation page that includes MKLLUFactorization and prints hardware info showing it was run on AMD EPYC.

I'm not 100% sure what happens when MKL is force-enabled on AMD hardware, though. Maybe it falls back to something else? Regardless, the crash on my Github CI was indeed MKL-related and fixed with this PR. 🤷

@ChrisRackauckas
Copy link
Member Author

This package also directly uses MKLLUFactorization(), so I'm not sure why that case wouldn't've done it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants